Configure density and gradient corrections independently - #1285
Draft
svchb wants to merge 29 commits into
Draft
Conversation
This was referenced Aug 15, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1285 +/- ##
==========================================
- Coverage 90.49% 90.27% -0.23%
==========================================
Files 141 149 +8
Lines 11419 12200 +781
==========================================
+ Hits 10334 11013 +679
- Misses 1085 1187 +102
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
svchb
force-pushed
the
feature/independent-correction-configuration
branch
from
August 16, 2026 13:33
51b854d to
16a6542
Compare
Fix conflicts in EDAC and WCSPH RHS: - adopt mapreduce_neighbor / add_dv_* functional API from origin/main - preserve gradient/force correction splitting from stack (gradient_correction for pressure/shifting, force_correction for free-surface)
…ecycle to restore stack diff
…tion-pressure-conservation # Conflicts: # src/schemes/fluid/entropically_damped_sph/rhs.jl # src/schemes/fluid/weakly_compressible_sph/rhs.jl # src/schemes/structure/structure.jl
…ion' into fix/asymmetric-correction-pressure-conservation # Conflicts: # src/general/corrections.jl # src/schemes/fluid/entropically_damped_sph/rhs.jl # src/schemes/fluid/weakly_compressible_sph/rhs.jl # test/general/corrections.jl # test/general/corrections/gradient.jl # test/general/corrections/kernel.jl
…orrection-configuration # Conflicts: # src/schemes/fluid/entropically_damped_sph/rhs.jl # src/schemes/fluid/weakly_compressible_sph/rhs.jl # src/schemes/structure/structure.jl
…t-correction-configuration # Conflicts: # src/schemes/structure/structure.jl # test/general/corrections/common.jl
svchb
added
enhancement
svchb
added a commit
that referenced
this pull request
Sep 1, 2026
…tly into drafty_draft # Conflicts: # examples/fluid/dam_break_2d.jl
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CorrectionConfigurationfor independent density and gradient correctionsdensity_correctionandgradient_correctionkeywords to WCSPH, EDAC, and dummy boundariescorrectionkeyword and reject ambiguous mixed configurationStack
Depends on #1289 and therefore on the complete correction-method stack. This PR targets
mainand temporarily includes the preceding commits.Review-only diff: svchb/TrixiParticles.jlOpen@fix/asymmetric-correction-pressure-conservation...feature/independent-correction-configuration
Isolated layer: 10 files, 194 additions, 13 deletions.
Verification
git diff --checkpassed